On Wed, 22 Apr 2009, Szak�ts Viktor wrote:

Hi,

> I'm implementing .po -> .hbl generation in hbmk2 and noticed
> two issues:
> 1) __I18N_potArrayToHash() will RTE if the first param isn't an array.
> This can happen in hbi18n if __I18N_potArrayLoad() in LoadFiles()
> fails for some reason (.po open error or parsing problems).

It cannot happen. ErrorMsg() does not return.

> Similar RTE happens in LoadFiles() if one of the additional .po
> files has any errors. (as a minor thing, open error is shown to
> happen at the preceding file's last line)

Here also no RTE for the same reason as above.

I guess that you have RTE in modified version you used in hbmk2 where
you probably removed ErrorMsg() function call not in hb18n program.

> 2) When specifying multiple input .po files, the generation
> process is very slow even if the additional .po input file is small.

The difference is only in __I18N_POTARRAYJOIN(). It's .prg function
so it's not very fast. The additional overhead can be caused by
merging files with exactly the same messages so it's necessary
to make deeper analyzing and merge translations, plural forms,
source file and line information, etc.
Anyhow it still should not be slow process. At least I cannot observe
anything what is worth to talk about it on my computer when I'm using
hb18n. If it's a problem then please send to me your .pot files so
I can make some tests to check what is the slowest part of merge
process and should be improved.

best regards,
Przemek
_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to