Hi Przemek, You must be right. Since you know much better how to fix these, please do whatever update needs to be done, I have a limited knowledge of Windows API and all the ugly details involved (MSDN is often not an answer), and I'm not a user of it at all, nor interested in understanding its "strange" details. I'm only interested in successful builds now.
My personal opinion is that we're spending way too much time for very little benefit on hbwin's new wapi parts and gtwvg (and some other places). There isn't any other part of Harbour which causes that many build problems. I don't know how to solve this, but currently it's a huge waste of time IMO. We've finally dropped hbwhat and instead now we have the exact same amount of problems with above parts. It's probably possible to write fully correct Windows API code (though I'm starting to suspect that it's not), but currently some Harbour contribs parts fail in this area, and we're only talking about successful builds, not even successful test runs. Without cooperation/interest from authors, it's probably impossible to solve these. I hope Windows users will be able to help. [ In this specific case, without my recent patch it doesn't compile at all under mingw64, so I'm not sure what is the proper solution. ] Sorry for the rant. Brgds, Viktor On Thu, Mar 26, 2009 at 1:54 AM, Przemyslaw Czerpak <dru...@acn.waw.pl>wrote: > On Wed, 25 Mar 2009, vszak...@users.sourceforge.net wrote: > > Hi, > > > * contrib/gtwvg/gtwvg.h > > * contrib/gtwvg/wvggui.h > > ! Fixed to _not_ override _WIN32_IE. Overriding these version > > numbers is generally a very bad idea. Instead the code should > > adapt to whatever values are defined by system headers. > > This fixes most mingw64 errors. Please test other compilers. > > Many compilers does not set _WIN32_IE macro at all leaving the decision > to programmers. If this macro will not be defined to at least 0x0300 then > most of gtwvg code will not be usable. > So it has to be defined and it should be done before including windows > header files otherwise user will have to add it to CFLAGS. > In practice it means that sth like: > > #ifndef _WIN32_IE > #define _WIN32_IE 0x0400 > #endif > > should be added before any #include. > It can be added to gtwvg.h and > #include "gtwvg.h" > should be included as 1-st file in all .c files using it. > The same should be done in all other files which use extended WinAPI > functionality. > The default setting can be improved using some information from > machine type, f.e. Win64 builds for sure cannot be run with some > older windows version, f.e.: > #ifndef _WIN32_IE > #ifdef _WIN64 > #define _WIN32_IE 0x0501 > #else > #define _WIN32_IE 0x0400 > #endif > #endif > > It should also help to test the code for compilation with other versions. > Pritpal should decide about default value he needs for basic functionality. > User can overwrite it using HB_USER_CFLAGS. > For tests we can try to compile the code with different settings, f.e: > HB_USER_CFLAGS=-D_WIN32_IE=0x0200 > or: > HB_USER_CFLAGS=-D_WIN32_IE=0x0300 > but please remember that not all compiler properly use _WIN32_IE macro > to hide some definitions so such tests should be done with different C > compilers. > > BTW: in hbsetup.h you added: > ( defined(__POCC_TARGET__) && __POCC_TARGET__ == 2 ) > to detect HB_OS_WIN_CE builds. Maybe it's documented method in POCC > and in such case should be left but if not then I suggest to rather > use sth like: > ( defined( HB_OS_WIN ) && defined( _M_ARM ) ) > > best regards, > Przemek > > ps. with current code MinGW32 and MinGW32CE builds fails with: > > ../../gtwvg.c: In function 'hb_wvt_gtCreateToolTipWindow': > ../../gtwvg.c:4379: error: 'INITCOMMONCONTROLSEX' undeclared (first use in > this function) > ../../gtwvg.c:4379: error: (Each undeclared identifier is reported only > once > ../../gtwvg.c:4379: error: for each function it appears in.) > ../../gtwvg.c:4379: error: expected ';' before 'icex' > ../../gtwvg.c:4384: error: 'icex' undeclared (first use in this function) > ../../gtwvg.c:4387: warning: implicit declaration of function > 'InitCommonControlsEx' > _______________________________________________ > Harbour mailing list > Harbour@harbour-project.org > http://lists.harbour-project.org/mailman/listinfo/harbour >
_______________________________________________ Harbour mailing list Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
