Hi Viktor,

Il 01/11/2008 23.29, Szakáts Viktor ha scritto:

Hi Francesco,

xhb dependency is not a good solution for any
contribs.


I agree.

I strongly oppose this move, as I think it's the
wrong one in numerous ways (pls see my other mails).


ok, and I have already accepted it in previous mails. I have proposed the move because you told that you want to move hbdbgfx in hbwin because it works only in Windows env, as for my error in explaining, instead it works also in Linux, also if partially at this moment (see below).

Right now it seems hbdbgfx is separated to
not depend on xhb.lib, yet it still depends
on it for Linux. ?? I'm not sure I understand
the point of this.

Yes, because in Linux AFAIK does not exists equivalent of OutputDebugString() function, Giancarlo creates some code to emulate it.

After checked again both files I have remembered why I left lib so.
Because hb_outdebug() in xhb is defined at prg level instead I want to add it also for C level and unify it with mine functions. The intention was, but left incomplete, to redirect last part of work of hb_ToOutDebug() (visualization after formatting) to hb_outdebug() either for PRG than C level.

The proposal of hb_ToOutDebug() function is to have exactly same function for C and PRG levels having same syntax to help to debug apps.

It works banally at PRG doing:

PROCEDURE HB_ToOutDebug( ... )
   IF s_lToOutDebug
      hb_OutDebug( hb_sprintf( ... ) )
   ENDIF
RETURN

and at C level is similar also if I have not already added hb_OutDebug equivalent for linux. So now it works both in window and linux only from PRG level (using hboutdbg.c functions from xhb), instead at C level *actually* it works only for windows.

Anyway I think lib should IMO be removed from the
repository, or moved inside xhb.lib.

Unfortunately no one of you told any actual
issues regarding usage of xhb.lib for dbg functions
(like unwanted parts pulled in to the final .exe),
so I'll stop guessing, but for sure, if there are
any issues those should be solved inside xhb.lib
by those who find this enough of a problem.

It's not a solution to let xhb parts pour in
various other libs, or start to be duplicated
as separate parts.

I'd propose to move these functions inside
xhb lib, in case someone wants to deal with
the details of this, if not, and there are no
better ideas, I'll remove this lib from the
repository.


If you think that I can make above modifications (add C level call for them that alter code, also if just a little, from original xharbour file) I agree to move hbdbgfx into xhb.
Otherwise I will add above changes to hbdbgfx to make it complete.
Take your decision, I will follow it. If you want to delete hbdbgfx lib at all I will continue to have it in my repository as before.
I have added it because I thought it can be useful to someone.

Best regards

Francesco


_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to