On Sat, 09 Aug 2008, Szakáts Viktor wrote: Hi Viktor,
> We have hbfixdj.h. It's only included in one place > in hbsetup.h. > Do you see anything against merging this file into > hbsetup.h? It would look a bit more elegant IMO. It's a hack for using directly char type or wrongly casted to (int) to ctype functions. It causes that negative values are passed to this functions. I hope that I cleaned whole Harbour code and replaced all code like: char cVal; ... cVal = toupper( cVal ); or even worser: cVal = toupper( ( int ) cVal ); which effectively pacifies warnings leaving buggy code which still passes negative values on platforms where char is signed with: cVal = toupper( ( UCHAR ) cVal ); but I'm not sure so I haven't removed hbfixdj.h so far. If we hard code it inside hbsetup.h then we quite fast forget about it. Personally I have some other similar hbfix*.h files I'm using in my custom builds with some more exotic compilers and it is very good for me that I can only add simple #include to hbsetup.h best regards, Przemek _______________________________________________ Harbour mailing list Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
