Hi Pritpal,

From the list of stuff you proposed for inclusion in hbgtinfo.ch,
pls find my comment below.

- HB_GTI_SETFONT
  We already have HB_GTI_FONT*, so IMO we don't need another one.
- HB_GTI_USER
  should rather be HB_GTI_SPEC IMO, as it's not a "user" defined
  setting, but something specific to a given GT.

As for HB_GTU_* stuff (HB_GTS_* to be in sync with above), it
shouldn't go to hbgtinfo.ch, since GTWVG is not in core, so IMO
you should add a new public header hbgtwvg.ch to contrib/gtwvg
and #define these there. This header can then be added to the
header list in local Makefile/common.mak so that it will be
installed in central /include dir. This way programmers will be
better aware they are using something special, plus we're not
adding contrib dependency to the core.

Brgds,
Viktor

On 2008.06.14., at 21:04, Pritpal Bedi wrote:


2008-06-15 11:34 UTC+0800 Pritpal Bedi ([EMAIL PROTECTED])
  * contrib/gtwvg/gtwvg.c
  * contrib/gtwvg/gtwvg.h
  * contrib/gtwvg/wvtutils.c
  * contrib/gtwvg/wvtcore.c
  * contrib/gtwvg/wvtpaint.prg
  * contrib/gtwvg/wvtclass.prg
    + Implemented all features recently added in gtwvt.

  * contrib/gtwvg/tests/demowvg.prg
    * Just refreshed to match the date/time stamps with gtwvg.lib

    ; This is first attempt in this series of optimizations in gtwvg
      to synchronize it with gtwvt builing a basis for inheretance
      from gtwvt.

      Now all EXPORTed funtions in gtwvg.c are stripped and isolated
in wvtpaint.prg as prg code taking use of Hb_GtInfo() architecture.

gtwvg.c contains only static functions and as such GT layer is made self contained. For this to happen I had to define few more GTI_* constants which goes in gtwvg.h and local to wvtpaint.prg. One or two
      of them validly become candidate fot gtwvt/hbgtinfo.ch also.

TODO: To clean wvtutils.c by plugging the functionality in HB_GTINFO
            structure. Please do not update any of these files.

Regards
Pritpal Bedi
--
View this message in context: 
http://www.nabble.com/2008-06-15-11%3A34-UTC%2B0800-Pritpal-Bedi-%28pritpal%40vouchcac.com%29-tp17842480p17842480.html
Sent from the Harbour - Dev mailing list archive at Nabble.com.

_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

_______________________________________________
Harbour mailing list
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to