Hello William, Thank you for your patience and valuable feedback and reviews. Appreciate it. As you requested, I have broken the changes into 3 seperate patches to help with the review process. The first patch contains the 4 new fetches + the doc changes as I had originally submitted (with all the review comments addressed). The second patch contains just the new regression test added for the 4 new fetches (with the review comments addressed). The third patch has the most changes and contains the new helper method, `clnt_hello_proc smp_client_hello_parse` which does the initial processing of the client hello message that was common to the following fetches:
1. smp_fetch_req_ssl_st_ext 2. smp_fetch_req_ssl_ec_ext 3. smp_fetch_ssl_hello_sni 4. smp_fetch_ssl_hello_alpn 5. smp_fetch_ssl_supported_groups 6. smp_fetch_ssl_sigalgs 7. smp_fetch_ssl_keyshare_groups 8. smp_fetch_ssl_cipherlist The first 7 fetches do some additional processing based on the TLS extensions whereas the last one, `smp_fetch_ssl_cipherlist` does not. Instead it parses the CipherSuite field. This distinction has been made in the new helped function by using the boolean parameter `parse_extensions`. Fetches 1 to 7 will pass true and `smp_fetch_ssl_cipherlist` will pass `false`. You had mentioned to use a union for this but I wasn't sure how to use it here. Thank you once again for taking the time to review. Thanks, Mariam. Mariam John (3): PATCH-1: Add 4 new fetch function for client hello parsing PATCH 2: Add new reg-test for the 4 new fetches PATCH-3: Add new smp_client_hello_parse() function doc/configuration.txt | 66 +++ reg-tests/checks/tcp-check-client-hello.vtc | 81 +++ src/payload.c | 577 +++++++++++++------- 3 files changed, 537 insertions(+), 187 deletions(-) create mode 100644 reg-tests/checks/tcp-check-client-hello.vtc -- 2.39.3 (Apple Git-145)
