On Fri, Mar 21, 2025 at 05:08:17PM +0000, psavalle wrote: > > Thank you, pretty good work here! I have two requests below: > > These all sound good, here's an updated patch. I have also added the > directive to the 'index' in 'configuration.txt', which I had missed earlier.
Ah, I often miss it as well! > Thank you for taking a look so quickly! You're welcome, thanks to you for the quick turn around. I wish I had reviewed it earlier, it could almost have landed in -dev8. It all looks good to me, however I'm seeing a failure of the regtests here: ... **** c2 rxhdr|HTTP/1.1 503 Service Unavailable\r **** c2 rxhdr|content-length: 107\r **** c2 rxhdr|cache-control: no-cache\r **** c2 rxhdr|content-type: text/html\r **** c2 rxhdr|\r **** c2 rxhdrlen = 107 **** c2 http[ 0] |HTTP/1.1 **** c2 http[ 1] |503 **** c2 http[ 2] |Service Unavailable **** c2 http[ 3] |content-length: 107 **** c2 http[ 4] |cache-control: no-cache **** c2 http[ 5] |content-type: text/html **** c2 c-l|<html><body><h1>503 Service Unavailable</h1> **** c2 c-l|No server is available to handle this request. **** c2 c-l|</body></html> **** c2 bodylen = 107 ** c2 === expect resp.status == 200 ---- c2 EXPECT resp.status (503) == "200" failed **** c2b rxhdr|HTTP/1.1 504 Gateway Time-out\r **** c2b rxhdr|content-length: 92\r **** c2b rxhdr|cache-control: no-cache\r **** c2b rxhdr|content-type: text/html\r **** c2b rxhdr|\r **** c2b rxhdrlen = 103 **** c2b http[ 0] |HTTP/1.1 **** c2b http[ 1] |504 **** c2b http[ 2] |Gateway Time-out **** c2b http[ 3] |content-length: 92 **** c2b http[ 4] |cache-control: no-cache **** c2b http[ 5] |content-type: text/html ... I'll have a look but need to be away from keyboard for an hour now, I'm sharing this just in case you have an idea. I'm running with HAPROXY_TEST_TIMEOUT=400 if that can help (the 504 above makes me think it could be related but don't have the time to test otherwise now). Thanks! Willy
