On 3/3/25 17:37, Roberto Moreda wrote:
> Thank you for sharing your thoughts, I really appreciate it.
>
> I do really like the idea of having a regular frontend section with "mode
> log" in the future. Considering this, I fully agree on the approach that you
> suggest.
>
> Notes:
>
> * The new two options take two bits in the proxy->options2.
> * I replicate the loop to read options as it is in cfgparse-listen.c (only
> over options2). I added an explicit initialization px->options2 = 0.
>
Great, thanks for the quick turnaround!
It looks good to me. Just a few minor things:
> +
> +#define PR_O2_DONTPARSELOG 0x02000000 /* don't parse log messages */
> +#define PR_O2_ASSUME_RFC6587_NTF 0x04000000 /* assume that we are going to
> receive just non-transparent framing messages */
> /* unused : 0x0000000..0x80000000 */
I would add a small note in the comments to mention that they are
log-proxy specific. Also the 0x01000000 may be used instead of
0x04000000. Plus the "unused" comment below them should be updated.
> I'm attaching the new patch. I you prefer me to split it (or any other
> change), just let me know.
If you can split the patches (one for the options eval in
cfg_parse_log_forward()), one for prepare_log_message() and the last one
with the actual options, it would be super! I can do that on your behalf
if you want though :)
Thanks!
