please feel free to either apply or discard patch. сб, 8 февр. 2025 г. в 07:15, Willy Tarreau <w...@1wt.eu>:
> Hi Ilya, > > On Tue, Feb 04, 2025 at 10:50:24PM +0100, ???? ??????? wrote: > > well, there are ~10 unhandled "malloc" and ~3 unhandled "calloc" in 51d.c > > I'm against reviewing/fixing them altogether > > > > can we fix it step by step instead ? > > If you really need to fix them step by step, that can be OK, but you > just need to keep in mind that changing a function's construct to > handle bugs in a way that leaves bugs is always a pain to review and > even debug later. I think that there might be some cases where bugs > are sufficiently unrelated to be fixed separately, but for example > when you need to revisit the unrolling of a function's free() calls > at the end, you often need to do it all at once in the function, and > in this case I'd rather not try to reintroduce existing bugs for the > purpose of sticking to step-by-step, but rather commit a single > "revisit error paths in function foo() to properly release all > allocations". > > > as for missing space, I can fix (or this can be fixed when applying) > > OK noted, thanks! > Willy >
