ср, 30 окт. 2024 г. в 16:33, William Lallemand <wlallem...@haproxy.com>:

> Hello Ilya,
>
> I think you mixed up both patches, one commentary is about libreSSL but
> contains
> the aws-lc file, and the contrary for the other one.
>

yep. If you do not mind, can you fix it when applying ?
or I can send v2



>
> Regards,
>
>
> On Tue, Oct 29, 2024 at 09:49:01PM +0100, Ilia Shipitsin wrote:
> > Subject: [PATCH 1/3] CI: switch QUIC Interop on LibreSSL to common
> docker image
> > previously we used different docker images for different SSL libs,
> > now all of them are merged into one, lets switch to it
> > ---
> >  .github/workflows/quic-interop-aws-lc.yml | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/.github/workflows/quic-interop-aws-lc.yml
> b/.github/workflows/quic-interop-aws-lc.yml
> > index 0620d36fe..4546f9519 100644
> > --- a/.github/workflows/quic-interop-aws-lc.yml
> > +++ b/.github/workflows/quic-interop-aws-lc.yml
> > @@ -27,19 +27,16 @@ jobs:
> >            username: ${{ github.actor }}
> >            password: ${{ secrets.GITHUB_TOKEN }}
> >
> > -      - name: Clone docker image definition
> > -        run: |
> > -          git clone -b aws-lc
> https://github.com/haproxytech/haproxy-qns
> > -
> >        - name: Build and push Docker image
> >          id: push
> >          uses: docker/build-push-action@v5
> >          with:
> > -          context: haproxy-qns
> > +          context: https://github.com/haproxytech/haproxy-qns.git
> >            push: true
> > +          build-args: |
> > +            SSLLIB: AWS-LC
> >            tags: ghcr.io/${{ <http://ghcr.io/$%7B%7B> github.repository
> }}:aws-lc
> >
> > -
> >    run:
> >      needs: build
> >      strategy:
> > --
> > 2.46.0.windows.1
> >
> >
> >
>
> --
> William Lallemand
>

Reply via email to