Hi Nicolas, On Tue, Aug 20, 2024 at 11:08:33AM +0200, Nicolas CARPi wrote: > From 96f5e7951995be8216ecee81968b0f2c7fe0141a Mon Sep 17 00:00:00 2001 > From: Nicolas CARPi <nico-git@deltablot.email> > Date: Tue, 20 Aug 2024 10:39:17 +0200 > Subject: [PATCH] BUG/MINOR: stats-html: improve markup and fix css in dark > mode > > This patch concerns the HTML stats page: > * Update the Doctype to a modern one > * Add the "lang" attribute to the "html" tag. This is required by WCAG > Success Criterion 3.1.1 (accessibility standard) > * Fix the text color in dark mode for the Scope input field
Normally it's preferable to make one commit per functional change. Even if these ones touch the same thing, they seem to change totally unrelated stuff (doctype, lang, color preference). Also what's the motivation/impacts of the first one? Does it render better or avoid a warning on some clients, is it just because it's cleaner, etc ? In this case maybe that one should just be tagged cleanup and the other ones minor. That's low importance, but I prefer that we don't start mixing unrelated changes in a single commit (and some might argue for backporting some of them, e.g. the color or lang). Thanks! Willy
