Hi Willy and the team, I just want to send a friendly reminder that I am still looking for feedback for this patch.
I totally understand that there might be other priorities coming up. When you get a chance, can you please take a look at the patch from my last email? Thank you. Ruei-Bang ________________________________ From: Ruei-Bang Chen <ruec...@linkedin.com> Sent: Friday, October 27, 2023 2:16 PM To: Willy Tarreau <w...@1wt.eu> Cc: haproxy@formilux.org <haproxy@formilux.org> Subject: Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names Hi Willy, Thanks for pointing that out. I have merged them into a single patch and attached it in this email. I'll keep that in mind when I send patches for review in the future. Ruei-Bang ________________________________ From: Willy Tarreau <w...@1wt.eu> Sent: Thursday, October 26, 2023 8:13 PM To: Ruei-Bang Chen <ruec...@linkedin.com> Cc: haproxy@formilux.org <haproxy@formilux.org> Subject: Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names Hi Ruei-Bang, On Fri, Oct 27, 2023 at 01:44:30AM +0000, Ruei-Bang Chen wrote: > Hi Willy, > > Thanks for the feedback! > > I have attached the 2 patches (with one being the same old patch and the > other having the diff since that older patch) to address the comments. > > Not sure if this is the preferred way for sending modification based on > previous patch. Let me know if you want a single patch for everything. Thanks! Indeed, the preferred way is to remerge them so that we don't merge an intermediary patch that works differently (think about a git bisect session that could fail between the two). I can also merge them myself, I'll just need to adapt your commit messages. So it's as you want. If you can do them right now I will appreciate it, if you don't have the time before the week-end, I'll do it myself. Thanks! Willy
