Hi Bertrand,

On Sat, Dec 17, 2022 at 09:39:38PM +0000, Bertrand Jacquin wrote:
> testdir can be a very long directory since it depends on source
> directory path, this can lead to failure during tests when UNIX socket
> path exceeds maximum allowed length of 97 characters as defined in
> str2sa_range().
> 
>   16:48:14 [ALERT] ***  h1    debug|    (10082) : config : parsing 
> [/tmp/haregtests-2022-12-17_16-47-39.4RNzIN/vtc.4850.5d0d728a/h1/cfg:19] : 
> 'bind' : socket path 
> 'unix@/local/p4clients/pkgbuild-bB20r/workspace/build/HAProxy/HAProxy-2.7.x.68.0/AL2_x86_64/DEV.STD.PTHREAD/build/private/HAProxy-2.7.x/src/reg-tests/lua/srv3'
>  too long (max 97)
> 
> Also, it is not advisable to create UNIX socket in actual source
> directory, but instead use dedicated temporary directory create for test
> purpose.

Ah good catch indeed! In addition this could also make tests randomly
fail if multiple were run in parallel with different settings.

Now merged, thank you!
Willy

Reply via email to