Transform the unreachability comment into a call to `my_unreachable()` to allow
the compiler from benefitting from it.
see d1b15b6e9b4d4d378a6169929a86f25b95eafc57
see 615f81eb5ad3e8c691901db8ce3e6a4a6b6efa49
---
src/connection.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/connection.c b/src/connection.c
index 1d53eed79..f78028451 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -1073,9 +1073,8 @@ int conn_recv_proxy(struct connection *conn, int flag)
if (!isttest(conn->proxy_authority))
goto fail;
if (istcpy(&conn->proxy_authority, tlv,
PP2_AUTHORITY_MAX) < 0) {
- /* This is technically unreachable,
because we verified above
- * that the TLV value fits.
- */
+ /* This is impossible, because we
verified that the TLV value fits. */
+ my_unreachable();
goto fail;
}
break;
@@ -1087,9 +1086,8 @@ int conn_recv_proxy(struct connection *conn, int flag)
if (!isttest(conn->proxy_unique_id))
goto fail;
if (istcpy(&conn->proxy_unique_id, tlv,
UNIQUEID_LEN) < 0) {
- /* This is technically unreachable,
because we verified above
- * that the TLV value fits.
- */
+ /* This is impossible, because we
verified that the TLV value fits. */
+ my_unreachable();
goto fail;
}
break;
--
2.35.1
