Hi Florian,
On Tue, Mar 30, 2021 at 01:42:55PM +0200, Florian Apolloner wrote:
> Hi there,
>
> I am a first time contributor, so please be gentle -- I most certainly did
> something wrong. I tried to follow as much as possible of the CONTRIBUTING
> file but I most likely CC'ed the wrong person or something (if that is the
> case, I apologize in advance).
Well, for a first one it was pretty good :-) I've readjusted the subject
as we use some tags to qualify the nature of the change (feature or bug)
and the approximate area ("stats" here) to help triage them, but that's
all.
> While playing with HAProxy I noticed that the status page currently does not
> ever seem to show a backend as orange ("active DOWN, going up"). If I read
> the code correctly this is due to a broken usage of strcmp which tries to
> compare "DOWN 3/5" with "DOWN " (note the trailing blank). I have adjusted
> it to strncmp and now backends that are down and going up are displayed
> orange again. I have also done the same for the "NOLB " case.
This is interesting because on my first reading I was surprised because I
was used to see them in yellow and thought that it was what you called
orange. But actually you're totally right, yellow is supposed to be for
up going down, not down going up. And I don't recall having seen that
orange for a long time now.
I introduced this issue myself 5 years ago when we've split the stats
output from its processing path, with commit 0c378efe8 ("MEDIUM: stats:
compute the color code only in the HTML form"). This may explain why I
don't recall having seen orange for a while!
Now applied, thank you!
Willy
