Hi Pieter, Your patch makes sense ! Good catch. Willy, could you apply ?
Thierry > On 29 Aug 2018, at 21:29, PiBa-NL <[email protected]> wrote: > > Op 29-8-2018 om 14:29 schreef Olivier Houchard: >> On Wed, Aug 29, 2018 at 02:11:45PM +0200, Frederic Lecaille wrote: >>> This patch is in relation with one bug reproduced by the reg testing file >>> sent by Pieter in this thread: >>> https://www.mail-archive.com/[email protected]/msg31079.html >>> >>> Must be checked by Thierry. >>> Must be backported to 1.8. >>> >>> Note that Pieter reg testing files reg-tests/lua/b00002.* come with this >>> patch. >>> >>> >>> Fred. >>> From d6d38a354a89b55f91bb9962c5832a089d960b60 Mon Sep 17 00:00:00 2001 >>> From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= <[email protected]> >>> Date: Wed, 29 Aug 2018 13:46:24 +0200 >>> Subject: [PATCH] BUG/MAJOR: thread: lua: Wrong SSL context initialization. >>> >>> When calling ->prepare_srv() callback for SSL server which >>> depends on global "nbthread" value, this latter was not already parsed, >>> so equal to 1 default value. This lead to bad memory accesses. >>> >>> Thank you to Pieter (PiBa-NL) for having reported this issue and >>> for having provided a very helpful reg testing file to reproduce >>> this issue (reg-test/lua/b00002.*). >>> >> That sounds good, nice catch ! >> >> And yes thanks Pieter, as usual :) >> >> Olivier > > As you've probably already verified, the issue is indeed fixed with this > patch applied on top of master. > > Thanks Frederic & Olivier. > > @Thierry, can you give the 'all okay' ? (or not okay, if it needs a different > fix..) > > Regards, > PiBa-NL (Pieter) >
