Hi Jonathan, On Wed, Mar 07, 2018 at 09:38:00PM +0000, Jonathan Matthews wrote: > On Wed, 7 Mar 2018 at 09:50, Nikhil Kapoor <[email protected]> wrote > > > As currently, no parsing error is displayed when larger value is given to > > "inter" parameter in config file. > > > > After applying this patch the maximum value of "inter" is set to 24h (i.e. > > 86400000 ms). > > > > I regret to inform you, with no little embarrassment, that some years ago I > designed a system which relied upon this parameter being set higher than 24 > hours. > > I was not proud of this system, and it served absolutely minimal quantities > of traffic ... but it was a valid setup. > > What's the rationale for having *any* maximum value here - saving folks > from unintentional misconfigurations, or something else?
I agree with you here. In fact what we should do is instead strengthen the timeout parser to emit errors when the parsed number overflows. The timer wraps around 49.7 days with a sliding window of half of it allowing 24.85 usable days to always be possible. That would be preferable and it wouldn't set any arbitrary had limits. Cheers, Willy
