Willy,

Am 20.11.2017 um 12:04 schrieb Willy Tarreau:
> But from what you explained (or at least what I understood), the mode
> specified in the unit file needs to match the build option. This is

If `Type=notify` is set then `USE_SYSTEMD` must be provided at build
time, yes. But as I outlined before: The Type must *also* match the
configuration (because whether the alternatives work correctly depends
on whether `daemon` is set or not).

> not really cool, especially for users who want to replace their distro's
> binary without having to modify the settings. Like William, I tend to
> think that it's best if the behaviour can be changed at runtime with
> an option. In my opinion it's less cognitive load to know that when you
> build, the existing unit file will automatically pass the appropriate
> option for its own settings (ie -Ws when using type=notify or -W for
> type=forking for example).

Is it possible to modify the unit file depending on the build flags?
Then I absolutely agree that `Type=notify` should be taken out if
`USE_SYSTEMD` is not set.

See my sibling mail for another suggestion to avoid the "silent failure"
when `USE_SYSTEMD` is not provided.

Best regards
Tim Düsterhus

Reply via email to