On Tue, Nov 08, 2016 at 04:36:21PM +0100, Scientiamobile wrote:
> Hi Willy
> 
> Everything in your patch in order to augment code isolation is fine (we
> just checked it locally), thank you !
> From our point of view, you can proceed to merge it in 1.7-dev

OK, will do it then, thanks for your feeback.

> Some words about your performance/accuracy benchmarks:
> - Performance mode speeds up detection only when working on a mix of
> desktop web browsers and devices traffic user agents (since it is basically
> a faster matcher for desktop web browsers that does not attempt the match
> the real browser). In your test case user agent is never recognized as a
> web browser so "accuracy mode" performs better than "performance mode"

That totally makes sense, thanks.

Willy

Reply via email to