Hi Shlomi, On Sun, Aug 21, 2016 at 12:49:07PM +0200, Shlomi Noach wrote: > As described in https://github.com/openark/haproxy/pull/1, this patch/PR > supports transitioning from DOWN state directly into NOLB. > > Current existing status only allows transitioning from DOWN to UP and then > to NOLB. > > I suggest updating the behavious via backwards compatible introduction of > new configuration variable: > > allow-down-to-nolb > > defaults: false (preserve existing behavior)
I think that definitely makes sense, as it was a question I had in mind when I designed the disable-on-404 feature several years ago, but we didn't have an immediate use for it, so we went for the simplest solution. > I'm unsure what's the correct flow for submitting a patch at this time, > let's please continue discussion. The best way is to send it here in git-format-patch output format, either as one patch if it's self-contained, or as several patches if it performs some infrastructure changes, so that anyone can comment on it. It's preferable to indicate your intent when you send a patch, ie is it for merging or just an RFC patch for people to comment on. That way if everything is alright, it can get merged quickly. Please have a look at the file "CONTRIBUTING" in the source tree for more details. cheers, Willy
