On Sat, 10 Oct 2020 22:47:01 +0200 "Silvan Jegen" <[email protected]> wrote:
Dear Silvan, > I think libgrapheme is a very good idea! I have just one comment > below. thanks for taking your time to review this commit and give feedback. I really appreciate it! > > +The > > .Nm > > -is a C library for working with grapheme clusters. What are > > grapheme -clusters? In C, one usually uses 8-Bit unsigned integers > > (chars) to -store strings, and many people assume that one such > > char represents -one visible character in a printed output. > > +library provides functions to properly count characters > > +.Dq ( grapheme clusters ) > > I feel like it should be made clear that from that point on, when the > man page mentions a "character" it refers to a grapheme cluster. The > reader can then either look up its definition or you could give a > short description together with it. > > That should make the uses of "character" further down less amibiguous > for the reader who is not familiar with the concept of a grapheme > cluster. > > Just my two cents! This is a good point. I worked this into the manpage in commit 706b4d4c. Is it clearer now or do you have further ideas to improve it? With best regards Laslo
