Nico Rikken via "Development of GNU Guix and the GNU System distribution." <guix-devel@gnu.org> writes:
> Hi all, > > I recently contributed the Ansel photo editor in gnu/packages/photo.scm > https://codeberg.org/guix/guix/pulls/85 > > Ansel is a fork of Darktable, and both use the rawspeed library: > https://github.com/aurelienpierreeng/ansel/blob/master/.gitmodules > https://github.com/darktable-org/darktable/blob/master/.gitmodules > > I assume it would be best to remove this duplication. > > The git submodule is placed in src/external/rawspeed from where it gets > included by CMake. > > > Can somebody help me make this improvement? Here are my questions: > > - Am I right to package this shared dependency? > - How should I name it? librawspeed? > - How do I package the library and add it to the applications so that > CMake can use it? Is there prior work for inspiration? > > Kind regards, > Nico Rikken Hi Nico, Sorry for the late response, your mail got buried in my todo list :P Anyways, your initial thoughts are very good. You can make a separate package for Rawspeed. If you use the cmake-build-system on your package it will install everything needed for being found as a library. In terms of name, etc… its just like any other library package. I would call it rawspeed. Lastly, you might need to patch ansel and darktable so that they search for the package with find_package instead of trying to use a submodule. Ideally, you would do this for all the other submodules that are libraries or executables. Feel free to ask more questions, I will answer faster! Have a nice day, Noé
signature.asc
Description: PGP signature
