Ludovic Courtès <l...@gnu.org> writes: > [..] > > Expiry is expressed as a duration. I’m skeptical about expressing it as > a number of files. > > One thing we could do is make #:expiry a procedure taking a file name > and returning its expiry.
I have to admit I just do not fully get the thought process behind the current design, so I wanted the option of "keep X old" to work around my ignorance. :) Right now, the initial rotation is based on *size*, but the number of kept old files is based on *age*. Would you be able to shed some light on why did you go in this direction? Honestly my expectation would be that size (for old files cumulative) would be used for both. > [..] > >> What is your opinion on turning the log rotation into a plug-able >> mechanism? I did not look too closely yet how this part of code works, >> but for example being able to set global parameter to a callback to do >> the log rotation could allow lot of flexibility while keeping it out of >> Shepherd itself. > > We could expose more extension points. > > (It would also be possible to maintain a separate log rotation tool > outside the Shepherd: there’s a well-defined protocol to query the log > files of services and to perform atomic rotation.) > I will look into that. :) Tomas -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors.
signature.asc
Description: PGP signature
