> Hi Artyom, Hello Ludovic!
> In the previous discussion, this was found to break the system test: > > https://bugs.gnu.org/75309 Oh, thanks! I didn't know about this issue. I removed the custom "check" phase and make arguments (see the attached patch), and then ran tests on dico 2.12 -- all the tests went fine: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build --check --no-grafts dico [...] phase `compress-documentation' succeeded after 0.0 seconds successfully built /gnu/store/r4zyf4fblfhmy9lcr1ranl402xw35pxx-dico-2.12.drv successfully built /gnu/store/r4zyf4fblfhmy9lcr1ranl402xw35pxx-dico-2.12.drv /gnu/store/yml96imxi7qlbw627dzcbjd9mk30xzq6-dico-2.12 --8<---------------cut here---------------end--------------->8--- Also i tried to run "dico" binary and it seems to work as well.
From e9db93eaa2dc19d24ee66b4c9fa4684c1672a4f8 Mon Sep 17 00:00:00 2001
Message-ID: <e9db93eaa2dc19d24ee66b4c9fa4684c1672a4f8.1744644636.git.poptsov.art...@gmail.com>
From: "Artyom V. Poptsov" <poptsov.art...@gmail.com>
Date: Mon, 14 Apr 2025 18:28:34 +0300
Subject: [PATCH] gnu: dico: Remove a custom "check" phase.
* gnu/packages/dico.scm (dico)[arguments]<#:phases>: Remove "check" phase.
[#:make-flags]: Remove.
Change-Id: I3562e16365389e1377f3ea7997878b1849052849
---
gnu/packages/dico.scm | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/gnu/packages/dico.scm b/gnu/packages/dico.scm
index 58f6d771ac9..38f57dc24f5 100644
--- a/gnu/packages/dico.scm
+++ b/gnu/packages/dico.scm
@@ -55,19 +55,13 @@ (define-public dico
'(#:configure-flags (list (string-append "--with-guile-site-dir=" %output
"/share/guile/site/2.0")
"--disable-static")
- #:make-flags '("V=1")
#:phases (modify-phases %standard-phases
(add-before 'check 'silence-guile
(lambda _
;; Guile is too talkative, which disturbs the test
;; infrastructure. Gag it.
(setenv "GUILE_AUTO_COMPILE" "0")
- (setenv "GUILE_WARN_DEPRECATED" "no")))
- (replace 'check
- (lambda* (#:key tests? #:allow-other-keys)
- (when tests?
- ;; Test '71: append + dooffs + env' fails if $V is not 2.
- (invoke "make" "check" "V=2")))))))
+ (setenv "GUILE_WARN_DEPRECATED" "no"))))))
(native-inputs (list groff))
(inputs
(list m4 ;used at run time
base-commit: 0502a30d3192c7369a18b1b3bcd61ffe4d7d6acd
--
2.49.0
Should I merge the patch then? - avp -- Artyom "avp" Poptsov <poptsov.art...@gmail.com> Home page: https://memory-heap.org/~avp/ CADR Hackerspace co-founder: https://cadrspace.ru/ GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
signature.asc
Description: PGP signature
