Kierin Bell <ferns...@fernseed.me> writes: > Am I missing something, or would the code below do the same thing as > 'emacs-git-email'?
Based only on the docstring (haven't reviewed the code), _some_ of the things emacs-git-email does are accounted for. However, it's not clear how some situations are handled: 1. Do patch series pose a complication or they're handled naturally? I'm unfamiliar with 'vc-prepare-patch', so this may be an obvious question. 2. Is there a way to associate a branch with an issue-specific email address? This can be useful for future revisions. 3. Some of the git-format-patch defaults are set in a manner assuming its use with git-send-mail. As such, these defaults are unsuitable when the patches are sent without git-send-mail. Are such issues corrected for? I'm aware of one such option, but unsure if there are others. Specifically, the --thread option in git-format-patch. This is not an issue in the guix repo due to ./etc/git/gitconfig , but is something that comes up generally. There are some other minor conveniences that emacs-git-email adds, but they have more to do with its integration with magit and thus may not be suitable for addition to core. E.g., ability to review and set the sendemail.to setting for the repository. > Could we submit a patch upstream to Emacs to make sending patches to > projects like Guix easier? Regardless of above, and without speaking for the Emacs maintainers, I think such patches to core would be a useful addition from a user's perspective. -- Suhail
