Hi Danny,
guix-comm...@gnu.org skribis:
> commit 6cd15c83ab54b049f4bd3114ba971849ffe1fe66
> Author: Danny Milosavljevic <dan...@friendly-machines.com>
> AuthorDate: Mon Feb 3 12:54:34 2025 +0100
>
> gnu: Add dlib.
>
> * gnu/packages/machine-learning.scm (dlib): New variable.
>
> Change-Id: Id0240565dfe76c7cdf0d74917f1de6fcd2da9f24
[...]
> +(define-public dlib
> + (package
> + (name "dlib")
> + (version "19.24.6")
You may have seen this warning:
gnu/packages/machine-learning.scm:6413:0: warning: shadows previous
definition of `dlib' at gnu/packages/machine-learning.scm:1841:0
This effectively means that you upgraded ‘dlib’ without noticing.
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'chdir
> + (lambda _
> + (chdir "dlib")))
> + (replace 'check
> + (lambda _
> + ;; Following the instructions on the website.
> + (mkdir "../dlib/test/build")
> + (with-directory-excursion
> "../dlib/test/build"
> + (invoke "cmake"
> "..")
> + (invoke "cmake"
> "--build" "." "--config" "Release")
> + (invoke "./dtest"
> "--runall")))))))
Indentation is off here, I’d recommend using ‘guix style’.
Could you please either revert this commit or merge the two ‘dlib’
definitions, assuming the upgrade does not break any dependent? (You
can use ‘guix build -P1 dlib’ for example to check that.)
Thanks in advance,
Ludo’.
PS: I think it’s also a case showing how we could benefit from a
streamlined process where changes are merged only once they’ve had a
green light from CI.
