Hi Ludo'
On 17/06/2024 1:05 pm, Ludovic Courtès wrote:
Hi Ada,
Ada Stevenson <adansk...@gmail.com> skribis:
I'm currently trying to help test the changes to GRUB submitted in
issue #71348[1]. Unfortunately, `make check`, whilst building the
local Guix channel, authenticates every commit. That means commits not
signed by people in `guix-authorizations` will stop the channel from
building and prevents running any of the tests.
Bummer. :-(
I have tried to fix the issue by writing a patch:
This patch looks like the right thing to do.
I’m not sure how to integrate it though: in the general case, we
probably want to keep authentication enabled by default, but how to
allow users to easily disable it when using a personal checkout?
Initially this seems like it works, as it starts to index all of the
commits in the local checkout, which didn't occur beforehand, instead
immediately giving a `Git error: cannot locate remote-tracking branch
'origin/keyring'` (I've run `git fetch -a`, and my Savannah remote is
called `origin`).
Guix caches clones under ~/.cache/guix/checkout. It may be that there’s
a clone of your local repo there, but that the clone itself lack a copy
of the ‘keyring’ branch? (You can run ‘git fetch -a’ in there.)
I tried invoking the tests from within a `./pre-inst-env guix repl` and
managed to get both of the tests to run using my patch! They both passed
too. I think you're right, there must have been some sort of caching error.
Anyway, I'm new to contributing using Debbugs. Is there a way to tag an
issue as 'reviewed' or something like that? Or do I just send an email
saying I tested the patch and everything looks good? Let me know :-)
Thanks for testing!
You're welcome! Thanks for writing the patch.
Ludo’.
Warmly,
Ada
