Hi!

Romain GARBAGE <romain.garb...@inria.fr> skribis:

> Fixes a regression introduced in
> 1da873b0e23eceb3c239dd6dc6781debf23bec63, where the NAME field of the
> SPECIFICATION record type is forced to be a symbol as stated by the
> documentation.

Yay, that was fast!

> * src/cuirass/base.scm: Handle SPECIFICATION-NAME as a symbol.
> * src/cuirass/http.scm: Handle SPECIFICATION-NAME as a symbol.
> * src/cuirass/templates.scm: Fix template generation.

Bonus points if you can mention the affected procedures in the message
above (I can do it for you otherwise).

I tested it locally following the instructions from ‘README’.  One case
where we still get a type error is when triggering evaluation through
the web interface:

  wget --post-data="" -O/dev/null \
    http://localhost:8080/jobset/random/hook/evaluate

This leads to this backtrace in ‘cuirass web’:

--8<---------------cut here---------------start------------->8---
In cuirass/http.scm:
  1408:46  1 (url-handler #<input-output: socket 44> _ _)
In ice-9/boot-9.scm:
  1685:16  0 (raise-exception _ #:continuable? _)
In procedure string->symbol: Wrong type argument in position 1 (expecting 
string): random
--8<---------------cut here---------------end--------------->8---

Note that this in turn causes communication with ‘cuirass register’ over
the “bridge”, so there could be other issues there.

Thanks,
Ludo’.

Reply via email to