Hi,
On lun., 29 janv. 2024 at 17:44, Ludovic Courtès <l...@gnu.org> wrote:
> That used to be the case until commit
> 672d3d4a87839b0692c307df0edb66cd16bcbf1a, which enabled colors even when
> ‘INSIDE_EMACS’ is set.
>
> Pierre, do you remember what the rationale was?
I am not Pierre. :-) The context seems:
Guix search, colors and INSIDE_EMACS
Pierre Neidhardt <m...@ambrevar.xyz>
Tue, 04 Feb 2020 16:23:43 +0100
id:87blqeml4w....@ambrevar.xyz
https://lists.gnu.org/archive/html/guix-devel/2020-02
https://yhetil.org/guix/87blqeml4w....@ambrevar.xyz
Quoting [1]:
--8<---------------cut here---------------start------------->8---
> new d7545a6 ui: Only display link in capable terminals.
> new 672d3d4 ui: Don't disable colors when INSIDE_EMACS is set.
Forgive me if I missed the discussion, but I thought we had reached
rough consensus in favor of the status quo. What happened?
--8<---------------cut here---------------end--------------->8---
Then quoting [2]:
--8<---------------cut here---------------start------------->8---
I’ve reverted it in c2f9ea2b502a617bb69227d5f858eee9d4288a6a, also
because if was causing a test failure.
--8<---------------cut here---------------end--------------->8---
where c2f9ea2b502a617bb69227d5f858eee9d4288a6a reads,
--8<---------------cut here---------------start------------->8---
Revert "ui: Only display link in capable terminals."
This reverts commit d7545a6b538813e88195d084f75a3e87065c999e.
The commit led to a test failure in 'tests/guix-package-net.sh'. It
also led to disagreements discussed here:
https://lists.gnu.org/archive/html/guix-devel/2020-02/msg00353.html
Reverting until these are addressed.
--8<---------------cut here---------------end--------------->8---
and thus 672d3d4 had not been reverted. Let revert it since it does not
make sense without d7545a6, IMHO.
Cheers,
simon
1: Re: branch master updated (0aa0e1f -> 9b7f9e6)
Ludovic Courtès <l...@gnu.org>
Mon, 24 Feb 2020 16:31:06 +0100
id:87blpom285....@gnu.org
https://lists.gnu.org/archive/html/guix-devel/2020-02
https://yhetil.org/guix/87blpom285....@gnu.org
2: Re: 01/03: ui: Only display link in capable terminals.
Ludovic Courtès <l...@gnu.org>
Fri, 28 Feb 2020 00:16:25 +0100
id:87wo87aaeu....@gnu.org
https://lists.gnu.org/archive/html/guix-devel/2020-02
https://yhetil.org/guix/87wo87aaeu....@gnu.org
