Hi Felix, On Fri, Jul 14, 2023 at 09:52 AM, Felix Lechner wrote:
> Hi John, > > On Fri, Jul 14, 2023 at 9:37 AM John Kehayias > <john.kehay...@protonmail.com> wrote: >> >> Unfortunately >> I managed to clobber the author line in the git log after editing and >> testing locally, sorry about that! (Anything that can be done to fix >> that?) > > Giving proper attribution can be essential in group projects. You > could revert your commit and then re-commit the change with the > correct author. > I agree, which is why I had a minor panic upon seeing the wrong name in the git log on savannah after pushing (after having checked locally so much to make sure I got it right, I must have glossed over it in the final formation). Revert/re-commit seems how we have to handle it, thanks for that note. > How to handle it best depends on your dynamics with the injured party. > I personally never cared enough—especially not in the case of an > innocent mistake—but I know that some folks feel strongly about being > made whole. > I made sure Pierre was aware in the original patch thread and here, and see a response now... > Kind regards > Felix Thanks Felix! John
