On 17-09-2022 02:13, Jan Wielkiewicz wrote:
Forgot the patches...
Some problems(1) a single package per patch (minetest-naturalslopeslib can be done in a commit before minetest-exile)
(2) no superfluous version prefixes -- remove the "v" from (version "v0.3.8") and replace (commit version) by (commit (string-append "v" version)) (3) naturalslopeslib is lgpl2.1+, according to the README.md (4) In minetest-exile, input labels can be avoided by replacing + (add-after 'install 'install-dependencies + (lambda _ + (symlink (string-append + #$(this-package-input + "minetest-naturalslopeslib")+ "/share/minetest/mods/naturalslopeslib")
+ (string-append + #$output + "/share/minetest/games/exile/" + "mods/naturalslopeslib")))))))(5) Going by https://content.minetest.net/packages/Mantar/exile/, more specifically its Website link, the home page is https://exile.planetofnix.com/wiki/pmwiki.php?n=Main.HomePage
(6) According to the content.minetest.net page, you forgot to mention the CC-BY-SA-3.0 license.
(7) Patches need to be sent to guix-patc...@gnu.org, not guix-devel.(8) I found a directory utilities/ -- IIUC, these bundled mods aren't actually used by the game, so they could simply be removed in a snippet like minetest-naturalslopeslib
with
(add-after 'install 'install-dependencies
(lambda _
(symlink (search-input-directory inputs
"share/minetest/mods/naturalslopeslib")
(string-append
#$output
"/share/minetest/games/exile/"
"mods/naturalslopeslib")))))))
Some things I can confirm:
(1) the hash for mintest-naturalslopeslib matches
(2) likewise for minetest-exile
Note: I didn't actually try out these patches.
Greetings,
Maxime
OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
