Hello,
zimoun <zimon.touto...@gmail.com> writes: > On Wed, 04 May 2022 at 21:49, Kyle Meyer <k...@kyleam.com> wrote: > >> I've tried sit down and update Guix's public-inbox definition a few >> times, but there are various test failures that I didn't figure out how >> to handle in the time I had. (IIRC, I think they're related to the lei >> tests expecting to be able to kill the lei-daemon process, which isn't >> the case in Guix's build environment.) > > On Thu, 05 May 2022 at 00:13, Thiago Jung Bauermann <bauerm...@kolabnow.com> > wrote: > >> Yes, that's what I'm seeing as well. The lei-daemon process is actually >> killed, but because of bug 30948 it is left in a zombie state and so the >> testsuite thinks that it didn't go away. >> >> The testsuite checks whether lei-daemon is gone by doing a >> “kill(<lei-daemon pid>, 0)”, which unfortunately succeeds for zombie >> processes. >> >> I've been meaning to add child reaping to the Guix builder process, but >> I'm moving very slowly due to time constraints and my unfamiliarity with >> that part of Guix... > > …why not just disable the specific test or if not possible, turn off the > test suite ’#:tests? #f’. Whereas it is not the best, it would allow to > have ’lei’ while waiting the fix at the Guix build environment level. > > WDYT? I didn't go that route because I don't like disabling tests without understanding why they fail and it took me a while to understand the zombie root cause. In addition to that, without the testsuite passing I didn't feel confident that I would be proposing a good enough package because virtually the only part of public-inbox that I use is lei itself. What if there was a regression in other parts of it and I didn't notice because I use so little? But I wouldn't mind disabling the part that checks that lei-daemon is truly gone, or even the whole testsuite if that is too complicated. On the other hand, the preferred solution would be the workaround pointed out by Maxim, where tini is used to run the testsuite and reap its sub-processes. I can probably take a stab at it over the weekend if no one beats me to it. >> $ guix shell -p path/to/profile -- lei up --all > > How do you query all new ones for a specific list? > > > Thiago, do you use ’piem’ [1]? I don't, but it looks interesting! I'll try it out, thanks! > 1: <https://git.kyleam.com/piem/about/> -- Thanks Thiago
