Hi Chris, Chris Marusich <cmmarus...@gmail.com> writes:
> Mark H Weaver <m...@netris.org> writes: > >> Earlier, I wrote: >>> When invoking 'patch' in Guix, you should *always* use "--force" instead >>> of "--batch". >> >> (See <https://bugs.gnu.org/45252#19> for my earlier message). > > Thank you for letting me know about this. I didn't know about the > difference between "--batch" and "--force". I agree we should use > "--force" instead of "--batch". How do you recommend that I proceed? Simply changing "--batch" to "--force" on line 79 (in the powerpc64le-* case, i.e. the one that was just added) seems like the right thing. That will force a rebuild of almost everything on the powerpc64le-* architecture, but should not cause any rebuilds on other architectures. >> Since writing the message above, I've found another problem in the same >> commit (7eaa2f24ea77cddbb4bbc2d6a6905673a36f8f99): it searches for the >> 'patch' program in 'inputs'. This is a mistake, because when >> cross-compiling, 'inputs' will contain software compiled to run on the >> target system instead of the build system. > > Is it searching for the "patch" program, or is it searching for the > patch file? It looks to me like the code is searching for the patch > file in inputs, not the "patch" program. LOL, you're right, I got confused. Please disregard my second email in this thread, and apologies for that noise. > Again, thank you for taking the time to bring these topics up. I'm > always trying to make sure I do things the best way I can in Guix, so I > appreciate the feedback. Thank you, Chris. Warm regards, Mark
