On Fri, 20 Nov 2020 at 15:26, Ricardo Wurmus <rek...@elephly.net> wrote:
> > Just to understand for the next time: when should the commit upgrading > > the %bioconductor-version be done? First one or last one? > > > > (I am speaking of this kind of commit: > > ac6a55e68a6ed675a55abc5339f776613648cb9d) > > It doesn’t really matter; usually I do this first, so that for all > following commits the fallback URL is going to be the correct new URL. > I haven’t thought much about this, so there may be reasons involving > “guix time-machine” that are for or against that position. I will think a bit about that; especially related to #39885. <http://issues.guix.gnu.org/issue/39885> > It should, in my opinion, be done together with the other change to the > version string. Yes, for sure. :-) > We can and should rewrite history in the wip-r branch. So if you have a > fix you can add a new commit on top of wip-r branch and mark it so that > someone later can reorder and squash it before the merge into the master > branch. > > To avoid stepping on each other’s toes we should be adding commits to > the top and then agree on a freeze to reorder and squash those commits > in the end. Ok, that's make sense. Thanks. All the best, simon