Pierre Neidhardt <m...@ambrevar.xyz> writes:
> Hi Marius,
>
> Sorry, I rebased and edited a few things, some changes slipped through
> and resulted in this terrible commit :(
>
>> + (let ((commit "c4de15df559410aff0ca6643724e24cddb0ecbbd")
>> + (arch (match (or (%current-target-system)
>> + (%current-system))
>> + ("x86_64-linux" "x86_64")
>> + ("i686-linux" "i386")
>> + (_ ""))))
>> Don't do this if you just need to determine architecture at build time.
>
> Just to be sure, you suggest moving this inside the 'really-install
> phase, right?Yes. Otherwise it gets needlessly evaluated by the Guix "front-end" every time one uses 'guix search' etc -- even on unsupported architectures. It's better to do it at build time, especially when it is only used within a single phase. On a related note, the 'ccl' package has a similar issue, and actually produces an invalid derivation on aarch64 and armhf. It can be seen by running e.g. 'guix weather -s armhf-linux'. I've been meaning to file a bug about it forever, but typically just comment the package and forget about it. :-/
signature.asc
Description: PGP signature
