Hi Mark, Mark H Weaver <m...@netris.org> writes:
> Hi Timothy, > > guix-comm...@gnu.org writes: > >> samplet pushed a commit to branch core-updates >> in repository guix. >> >> commit d619686250d8bb15bf67031f8ac80f9cfb400a26 >> Author: Timothy Sample <samp...@ngyro.com> >> Date: Sun Jul 14 23:47:44 2019 -0400 >> >> gnu: evolution-data-server: Fix locale handling. >> >> * gnu/packages/gnome.scm (evolution-data-server)[arguments]: Add a phase >> that patches the source code to fix a locale handling issue. >> >> [...] > > IMO, we should use patches for things like this. Most importantly, the > 'substitute*' may silently do the wrong thing, or perhaps do nothing at > all, when the relevant code changes. The 'patch' program is far more > robust in such scenarios. Also, it would be good for fixes like this to > be included in the result of "guix build --source". > > What do you think? I agree completely. I was mostly put off by how cumbersome the patch system is for such a little change. In this case, I’m pretty sure none of the problems you’ve mentioned will happen, but that’s not a great excuse. This kind of feature-level change is exactly what the patch system is for. I’ve fixed my mistake in e1f174ae284d9954840f1723ac012c0d3fbcecb4. > Anyway, thanks for working on it. Thanks for the quality control! -- Tim
