Hello, Mark H Weaver <m...@netris.org> writes:
> Maxim Cournoyer <maxim.courno...@gmail.com> writes: [...] >> The way I see it, `guix download' should just do the right thing -- the >> metadata stripping should be baked in and not user >> controllable. Alternatively, it could be controllable, but enabled by >> default. This would keep the workflow the same as it is now. > > I *certainly* don't want "guix download" to try to automatically detect > that the downloaded file contains a patch, after some possibly > nontrivial amount of plain text which is typically present in patch > files, and to canonicalize the patch in that case. > > However, we could add an optional flag to "guix download", or perhaps > add another 'guix' subcommand, to request the use of a specific 'origin' > type. In addition to supporting canonicalized patches, this could also > improve the workflow for other origin types such as 'git-fetch' and > 'hg-fetch'. > > In general, the specified 'origin' type would determine the number and > meaning of the arguments, e.g. for 'git-fetch' an additional commit > argument would be needed. > > Thoughts? I like your idea, and it indeed sounds more straightforward from an implementation perspective. Maxim
