On 2018-11-22 02:02, swedebugia wrote:
Hi

On 2018-11-22 00:22, swedebugia wrote:
snip

snip

While investigating the top libraries* packages with most depends in npm I found the following:

Lib        Dep    DevDep    RecdevDep    Dependants    license
underscore    0    12    2400+        18000+        mit
async        1    37    2696        26069        mit

I succeded in packaging the latest underscore. I discovered a bug in the build system and fixed it to be able to build it. (see the diff attached)

Debian packaged a 4 year old async 0.8.0 that has 0 dep and only uglify-js as devdep (which we already have packaged). From 0.9.2 lodash was made a devdep.

--
Cheers
Swedebugia
modified   guix/build/node-build-system.scm                                     
                                                                              
@@ -1,6 +1,7 @@                                                                 
                                                                              
 ;;; GNU Guix --- Functional package management for GNU                         
                                                                              
 ;;; Copyright © 2015 David Thompson <da...@gnu.org>                            
                                                                              
 ;;; Copyright © 2016 Jelle Licht <jli...@fsfe.org>                             
                                                                              
+;;; Copyright © 2018 swedebugia <swedebu...@riseup.net>                        
                                                                              
 ;;;                                                                            
                                                                              
 ;;; This file is part of GNU Guix.                                             
                                                                              
 ;;;                                                                            
                                                                              
@@ -108,9 +109,13 @@ is an npm global install."                                 
                                                                              
                          (#f #f))))                                            
                                                                              
     (mkdir-p tgt-dir)                                                          
                                                                              
     (copy-recursively "." (string-append tgt-dir "/node_modules/" modulename)) 
                                                                              
-    ;; Remove references to dependencies                                       
                                                                              
-    (delete-file-recursively                                                   
                                                                              
-      (string-append tgt-dir "/node_modules/" modulename "/node_modules"))     
                                                                              
+    ;; Remove references to bundled dependencies                               
                                                                              
+    (let ((tgt-node-modules (string-append tgt-dir                             
                                                                              
+                                           "/node_modules/" modulename 
"/node_modules")))                                                              
      
+      ;; Check if tgt-node-modules exist and remove them if #t                 
                                                                              
+      (when (file-is-directory? tgt-node-modules)                              
                                                                              
+        (delete-file-recursively                                               
                                                                              
+         tgt-node-modules)))                                                   
                                                                              
     (when global?                                                              
                                                                              
       (cond                                                                    
                                                                              
         ((string? bin-conf)

Reply via email to