Mark H Weaver <m...@netris.org> writes: > Hi Marius, > > mba...@fastmail.com (Marius Bakke) writes: > >> mbakke pushed a commit to branch staging >> in repository guix. >> >> commit cb4b508cd68df89bfbd5255a0c5569f8318ad50f >> Author: Marius Bakke <mba...@fastmail.com> >> Date: Mon Jul 2 12:07:58 2018 +0200 >> >> build-system/meson: Really skip the 'fix-runpath' phase on armhf. >> >> This follows up commit d5b5a15a4046362377f1a45d466b43bb6e93d4f which >> doesn't >> work because %current-system etc expands before the actual build. > > I'm disappointed by this workaround that simply removes the > 'fix-runpath' phase on armhf. Is that phase needed, or is it truly > optional? What does the phase accomplish, and how will armhf users be > disadvantaged by the removal of that phase? > > This feels like "sweeping the problem under the rug" to me.
It *is* sweeping the problem under the rug, no doubt. The only alternatives I can see is fixing patchelf on armhf, which is difficult for me without access to hardware; fixing Meson itself, which may be easier, but then we may not be able to merge staging in a long time; or implement patchelf functionality in Guix as Ludovic started with <https://bugs.gnu.org/31028> and is currently in 'core-updates'. Do you have other suggestions? >> Fixes <https://bugs.gnu.org/31719>. > > I don't see the connection between that bug and this commit. > How does this commit fix that bug? Whoops, typo. It should be <https://bugs.gnu.org/31971>.
signature.asc
Description: PGP signature
