That code was indeed a bit wacky, I fixed it up. On Tue, 02 Jan 2018 23:25:48 +0100 l...@gnu.org (Ludovic Courtès) wrote:
> Hi, > > This is your friendly nitpicking bot! ;-) > > rhell...@mykolab.com (Rutger Helling) skribis: > > > "/bin/wine-preloader") > > (string-append (assoc-ref %outputs "out") > > "/bin/wine-preloader")) > > + ;; Copy the missing man file for the wine binary from > > wine-staging. > > + (system (string-append "gunzip < " (string-append > > (assoc-ref > > + %build-inputs "wine-staging") > > + "/share/man/man1/wine.1.gz") > > "> " > > + (string-append (assoc-ref > > %outputs "out") > > + "/share/man/man1/wine.1"))) > > #t)) > > The indentation of the nested ‘string-append’ calls is misleading here > (and the nested calls are unnecessary because ‘string-append’ is > n-ary.) > > Also, I think it’s OK to leave the file compressed (we have a man page > compression phase anyway.) > > Thanks! > > Ludo’.
pgpVoQ24gXVWj.pgp
Description: OpenPGP digital signature
