On Mon, May 29, 2017 at 07:22:18PM -0400, Mark H Weaver wrote:
> > Leo Famulari <l...@famulari.name> writes:
> >
> >> + (replace 'build
> >> + (lambda _
> >> + ;; Build 'libgs.so', but don't build the statically-linked
> >> 'gs'
> >> + ;; binary (saves 22 MiB).
> >> + (zero? (system* "make" "so" "-j"
> >> + (number->string
> >> (parallel-job-count))))))
> >
> > Couldn’t we just add “#:make-flags '("so")” and avoid replacing the
> > build phase?
>
> FWIW, I think it's a bad habit to abuse #:make-flags for targets,
> because the contents of #:make-flags is also passed to 'make' during the
> 'install' and 'check' phases.That's a good point. For this package I think we can just re-use the build phase replacement from the GNU Ghostscript package, as in v1 of my patch. > IMO, if we want to avoid replacing the build phase in cases like this, > it would be better to add a separate #:build-target argument. > > Thoughts? Yes, it could be useful.
signature.asc
Description: PGP signature
