On Mon, Apr 10, 2017 at 12:48:27AM +0200, Marius Bakke wrote:
> Not to pick on this patch, since this problem was present before..but:
> 
> "install-file" has an unspecified return value, so I don't think it's
> safe to use in an "and" block. The attached patch should be more
> correct. WDYT?
> 

> From e3bd8d6df932986c35a2f8088c491eb6f89ee6d5 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mba...@fastmail.com>
> Date: Mon, 10 Apr 2017 00:26:45 +0200
> Subject: [PATCH] gnu: certbot, python-acme: Build documentation in separate
>  phase.
> 
> * gnu/packages/tls.scm (python-acme)[arguments]<:phases>: Add
> 'build-documentation' phase. Rename 'docs' phase to 'install-documentation'.
> (certbot)[arguments]<:phases>: Adjust accordingly.

LGTM, thanks for being picky :)

Attachment: signature.asc
Description: PGP signature

Reply via email to