Hi Ludovic, Ludovic Courtès <l...@gnu.org> writes:
> Hi Clément, > > Clément Lassieur <clem...@lassieur.org> skribis: > >> I think there is a misunderstanding. I didn't want to push this because >> it was not tested, and because subsystems are often useless without >> Match, and Match is unsupported. The pair/list thing is not the >> problem. >> >> And I was waiting for ng0 to test, because he asked for this patch (see >> http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), so >> I thought he was able to test. >> >> If ng0 still needs the patch and confirms that it works well, I'm >> willing to update it. Otherwise, let's drop it. > > The patch looks like a useful addition. It would be sad to drop it, no? > > If you could add a test to (gnu tests ssh) that would be perfect, but > otherwise it LGTM. Perhaps the default value for ‘subsystems’ should > include internal-sftp though, as users probably expect sftp to just work. Yes, you are right. I changed my mind :) And the other distributions I've seen have SFTP enabled as well. So I updated the service, and I did a test: http://lists.gnu.org/archive/html/guix-patches/2017-03/msg00546.html. > I don’t have any issue with using two-element lists; I think the syntax > for pairs can be a bit confusing for newcomers to it’s probably better > to avoid it in service configuration. Ok, I used two-element lists then. Clément
