On Tue, Feb 14, 2017 at 12:28:28AM +0100, Mekeor Melire wrote: > From 04f94c306f99a7bacc96b60ed60e9bb83a9cf767 Mon Sep 17 00:00:00 2001 > From: Mekeor Melire <mekeor.mel...@gmail.com> > Date: Tue, 14 Feb 2017 00:21:08 +0100 > Subject: [PATCH] gnu: Add dzen. > > * gnu/packages/xdisorg.scm (dzen): New variable.
Thanks! > +(define-public dzen (package '(package ...' should start on the second line, underneath the 'e' of 'define'. There is a script 'etc/indent-code.el' in our Git repo that should handle indentation for you. > + (version "0.9.5") The version string should be constructed as shown in the manual section 'Version Numbers': https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Version-Numbers This ensures that we can distinguish between different versions of packages that are created from version control snapshots. > + (synopsis "General purpose messaging, notification and menuing program for > X11") > + (description "Dzen is a general purpose messaging, notification and menuing > +program for X11. It was designed to be fast, tiny and scriptable in any > language.") > + (home-page "https://github.com/robm/dzen";) > + (license license:x11) It's actually the Expat license: http://directory.fsf.org/wiki/License:Expat Also, these fields typically go at the end of the package definition. It makes no difference technically, but adhering to a common standard helps reading and understanding the package. > + #:tests? #f We must leave a comment explaining why tests are disabled. If there are no tests, then "No test suite." is enough. > + ; use our make-flags instead of `config.mk` > + #:make-flags (list > + (string-append "VERSION = " ,version) > + (string-append "PREFIX = " %output) > + "MANPREFIX = ${PREFIX}/share/man" > + "INCS = -I." > + "LIBS = -lc -lX11 -lXinerama -lXpm $(shell pkg-config --libs xft)" > + "CFLAGS = -Wall -Os ${INCS} -DVERSION=\\\"${VERSION}\\\"\ > + -DDZEN_XINERAMA -DDZEN_XPM -DDZEN_XFT $(shell pkg-config > --cflags xft)" I don't think we should use the shell, but instead use (assoc-ref) and (string-append) to get the right path. > + #:phases (modify-phases > + %standard-phases > + ; do not `./configure` Instead, how about "No ./configure script.", since it communicates more clearly why we delete this phase.
