Ludovic Courtès <l...@gnu.org> writes: > Ricardo Wurmus <ricardo.wur...@mdc-berlin.de> skribis: > >> * gnu/packages/lua.scm (lua5.2-lpeg): New variable. > > I think you didn’t get feedback on this one. > >> +(define-public lua5.2-lpeg >> + (package (inherit lua-lpeg) >> + (name "lua5.2-lpeg") >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (delete 'configure) >> + ;; `make install` isn't available, so we have to do it manually >> + (replace 'install >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let ((out (assoc-ref outputs "out")) >> + (lua-version ,(version-major+minor (package-version >> lua-5.2)))) >> + (install-file "lpeg.so" >> + (string-append out "/lib/lua/" lua-version)) >> + (install-file "re.lua" >> + (string-append out "/share/lua/" lua-version)) > > It would be best to avoid duplicating this phase since the only > difference is the version number. However, this is currently > inconvenient, so it’s probably fine to keep it, with an “XXX” comment.
I agree. I’ve added an XXX comment explaining why it’s duplicated with a reference to your email for a proposed change. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net
