Hi Jan!
I’d suggest these minor cosmetic changes:
diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 71595bf3c..d922914e9 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -337,7 +337,8 @@ permit managing file systems not included in libparted.")
(version "625")
(source (origin
(method url-fetch)
- (uri (string-append "https://github.com/unetbootin/unetbootin/archive/";
+ (uri (string-append
+ "https://github.com/unetbootin/unetbootin/archive/";
version ".tar.gz"))
(file-name (string-append name "-" version ".tar.gz"))
(sha256
@@ -353,18 +354,19 @@ permit managing file systems not included in libparted.")
(chdir "src/unetbootin")
(system* "lupdate" "unetbootin.pro")
(system* "lrelease" "unetbootin.pro")
- (system* "qmake")))
+ (zero? (system* "qmake"))))
(replace 'install
(lambda* (#:key outputs #:allow-other-keys)
(let* ((out (assoc-ref outputs "out"))
(bin (string-append out "/bin")))
(mkdir-p bin)
- (copy-file "unetbootin"
- (string-append bin "/unetbootin"))))))))
+ (install-file "unetbootin" bin)
+ #t))))))
(inputs
`(("qt-4" ,qt-4)))
(home-page "https://unetbootin.github.io/";)
(synopsis "Create bootable live USB images")
(description
- "UNetbootin creates bootable Live USB images.")
+ "UNetbootin allows you to create bootable USB images from ISO-9660 CD/DVD
+images.")
(license license:gpl2+)))
In addition, there’s one thing we need to fix from an FSDG perspective,
which is described here:
<https://libreplanet.org/wiki/Software_blacklist#unetbootin>.
Could you check whether the package can be adjusted to use this FUSBi
fork mentioned there, and send an updated patch?
TIA!
Ludo’.
