Leo Famulari <l...@famulari.name> skribis:
> On Mon, Jan 16, 2017 at 12:43:14AM -0500, Leo Famulari wrote:
>> * gnu/packages/crypto.scm (scrypt): New variable.
>
>> + (arguments
>> + `(#:phases (modify-phases %standard-phases
>> + (add-after 'unpack 'patch-command-invocations
>
> I realized this indentation is too far to the right.
>
>> + (synopsis "Memory-hard key derivation function")
>
> And the synopsis should probably be something like "Memory-hard
> encryption tool". At least, it should include "encryption tool".
Agreed.
Also:
> + (add-after 'unpack 'patch-command-invocations
> + (lambda _
> + (substitute* '("Makefile.in" "autocrap/Makefile.am")
> + (("command -p") ""))
> + #t))
It’s probably enough to patch Makefile.in, and it avoids triggering an
‘automake’ invocation due to Makefile.am being more recent.
The rest LGTM, thanks!
Ludo’.
