From: Marius Bakke <mba...@fastmail.com>
Subject: Re: [PATCH] gnu: Add python-hdf4.
Date: Thu, 22 Dec 2016 18:09:07 +0100
Thomas Danckaert <thomas.dancka...@gmail.com> writes:
Hi Guix,
this patch adds python-hdf4. I'm not sure if the line “Python-HDF4
is a fork of pyhdf.” in the description is necessary. The original
and “official” pyhdf (http://hdfeos.org/software/pyhdf.php) is
somewhat outdated (e.g. doesn't support python3).
The "official" pyhdf and this fork was released around the same
time and
have the same version number. Confusing! But I'll take your word
that
this one is better.
Yes, it seems it mirrors updates in the “official” one, and keeps the
same version numbers.
Regarding the patch, I wonder if it should go in (gnu packages
maths),
similar to how we put PDF libraries in pdf.scm and XML in xml.scm
etc.
But no strong opinion here.
I've wondered the same. Right now, h5py, which is a similar package
for HDF5, is also in python.scm, so I decided to add this package
next to it. As an aside, I find many packages in maths.scm are not
really “mathy” (“science” maybe), but anyway :-)
The 'check' phase seems to run the build again, and prints at the
end
"Ran 0 tests in 0.000s". Looking at the Github ".travis.yml", the CI
tool runs the command "nosetests" instead of 'python setup.py test'
like
python-build-system does by default. Can you try replacing the
'check'
phase with that command? You'll need 'python-nose' as a
native-input.
I hadn't noticed that. This patch adds nosetests, but that just
prints “Ran 0 tests in .005s”, so it seems there are no tests. Shall
we just delete the 'check' phase?
Other changes applied!
thank you,
Thomas
From 11a2988febff79775eb31bc8e5da09fdea7d2269 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.dancka...@gmail.com>
Date: Thu, 22 Dec 2016 11:17:44 +0100
Subject: [PATCH] gnu: Add python-hdf4.
* gnu/packages/python.scm (python-hdf4, python2-hdf4): New variables.
---
gnu/packages/python.scm | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index bfa7eae..cc53f76 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -33,6 +33,7 @@
;;; Copyright © 2016 Arun Isaac <arunis...@systemreboot.net>
;;; Copyright © 2016 Julien Lepiller <jul...@lepiller.eu>
;;; Copyright © 2016 Tobias Geerinckx-Rice <m...@tobias.gr>
+;;; Copyright © 2016 Thomas Danckaert <p...@thomasdanckaert.be>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -715,6 +716,41 @@ certificate returned by the server to which a connection has been established,
and verifies that it matches the intended target hostname.")
(license license:psfl)))
+(define-public python-hdf4
+ (package
+ (name "python-hdf4")
+ (version "0.9")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri name version))
+ (sha256
+ (base32
+ "1hjiyrxvxk9817qyqky3nar4y3fs4z8wxz0n884zzb5wi6skrjks"))))
+ (build-system python-build-system)
+ (native-inputs `(("nose" ,python-nose)))
+ (propagated-inputs `(("numpy" ,python-numpy)))
+ (inputs
+ `(("hdf4" ,hdf4)
+ ("libjpeg" ,libjpeg)
+ ("zlib" ,zlib)))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (replace 'check
+ (lambda _ (zero? (system* "nosetests")))))))
+ (home-page "https://github.com/fhs/python-hdf4")
+ (synopsis "Python interface to the NCSA HDF4 library")
+ (description
+ "Python-HDF4 is a python wrapper around the NCSA HDF version 4 library,
+which implements the SD (Scientific Dataset), VS (Vdata) and V (Vgroup) API’s.
+NetCDF files can also be read and modified. Python-HDF4 is a fork of
+@url{http://hdfeos.org/software/pyhdf.php,pyhdf}.")
+ (license license:expat)))
+
+(define-public python2-hdf4
+ (package-with-python2 python-hdf4))
+
(define-public python-h5py
(package
(name "python-h5py")
--
2.7.4