Hi John,
John Darrington <j...@gnu.org> writes:
> * gnu/packages/guile.scm (guile-ncurses) [arguments]: Install shared object
> before
> attempting to build the package. Patch load-extension path before building
> instead
> of after.
The first sentence above is mistaken or misleading:
"Install shared object before attempting to build the package."
Of course this is not possible, and it's not what happens after applying
this commit.
> + (add-before 'build 'fix-libguile-ncurses-file-name
> (lambda* (#:key outputs #:allow-other-keys)
> - [...]
> + (and (zero? (system* "make" "install"
> + "-C" "src/ncurses"
> + "-j" (number->string
> + (parallel-job-count))))
> + (let* ((out (assoc-ref outputs "out"))
> + (dir "src/ncurses")
> + (files (find-files dir ".scm")))
> + (substitute* files
> + (("\"libguile-ncurses\"")
> + (format #f "\"~a/lib/guile/2.0/libguile-ncurses\""
> + out)))
> + #t)))))))
By running "make install -C src/ncurses [...]", you are in fact causing
most if not all of the package to be built and installed right here in
the 'fix-libguile-ncurses-file-name' phase. This is no good.
Can you help me understand what you're trying to do here, and why?
Thanks,
Mark
