On Tue, Dec 06, 2016 at 11:41:24AM +0100, Hartmut Goebel wrote:
> Am 05.12.2016 um 22:33 schrieb Leo Famulari:
> > +             (substitute* "testing/test_argcomplete.py"
> > +               (("def test_remove_dir_prefix" line)
> > +                (string-append "@pytest.mark.skip"
> > +                               "(reason=\"Assumes that /usr exists.\")\n   
> >  "
> > +                               line)))
> 
> These trailing spaces in the replacement string are a bit irritating.
> Perhaps its better to search for "^\s+def …" and replace with "   
> @pytest.skip…" (leading spaces here). I don't know.
> 
> Otherwise LGTM.

Should we try this with your Sphinx update patches on a python-updates
branch? After staging is merged?

Reply via email to